Skip to content

Conversation

@bbakerman
Copy link
Member

No description provided.

Copy link
Member

@andimarek andimarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great overall .. see my comments

date = 2018-11-24T01:00:00+10:00
+++

One of the most common questions we get in graphql-java land is "can we have a datetime scalar".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use GraphQL Java instead of graphql-java when I talk about the project/orga.


One of the most common questions we get in graphql-java land is "can we have a datetime scalar".

This is not defined by the graphql specification per se so we are reluctant to add it to the core library and then have it turn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL

This is not defined by the graphql specification per se so we are reluctant to add it to the core library and then have it turn
up later as an officially specified type.

But it really is a badly needed type in your graphql arsenal and hence graphql-java-extended-scalars was born
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL


https://github.com/graphql-java/graphql-java-extended-scalars

This will be a place where we can add non standard but useful extensions to graphql-java.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GraphQL Java

@bbakerman
Copy link
Member Author

Fixed PR concerns

@bbakerman bbakerman merged commit 4687936 into master Nov 26, 2018
@andimarek andimarek deleted the extended-scalar-blog branch January 23, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants