Reference resolving for federation support

[fabianriewe]

Hello,
I am currently working on a project where I use the Apollo Federation Gateway and graphene-federation to connect multiple Microservices. For each external Type I need to add the following resolver to the type.

def __resolve_reference(self, info, **kwargs):
    return MY_MODEL.objects.get(id=self.id)

Couldn't we just add something like the following to the MongoEngineObjectType?

@classmethod
def __resolve_reference(cls, info):
    return cls._meta.model.objects.get(id=self.id)

The only problem is that we need to resolve the reference by the Types key which isn't alwasy the id (just in my case). It could be any property of the model.

Thanks!

[abawchen]

@fabianriewe : thanks for late reply ..., it's okay to plug your idea to MongoengineObjectType, but before it, I have 2 quick questions need your feedback

• there is something like as below, does it not fit your case?
  

  graphene-mongo/graphene_mongo/types.py

  Lines 209 to 211 in 9a894cc

  	@classmethod
  	def get_node(cls, info, id):
  	return cls._meta.model.objects.get(pk=id)

• second, it maybe not a @classmethod since we need self, so it probably be

  def __resolve_reference(self, info):
      return self._meta.model.objects.get(pk=self.id)

make sense?

[fabianriewe]

The get_node function would fit the usecase. But it's required to call it '__resolve_reference' due to the Apollo Federation spec (https://www.apollographql.com/docs/apollo-server/federation/implementing-services/#gatsby-focus-wrapper). And yes we need to remove the @classmethod.

[abawchen]

@fabianriewe : I have added it on branch feat-add-resolve_reference, would you please verify it fits your need or not? Thanks.

[fabianriewe]

Hey! I looked deeper into this function and found out that we can improve it by using the following:

    def __resolve_reference(self, info, **kwargs):
        # construct filter for keys
        keys = {}
        for key in self._keys:
            keys[key] = self.__getattribute__(key)

        return self._meta.model.objects.get(**keys)

By using this the query is much more generic and doesn't rely on an key("id")