Skip to content

Conversation

erikwrede
Copy link
Member

@erikwrede erikwrede commented Jun 9, 2022

See corresponding discussion #345
Fixes #336

Co-authored-by: Viktor Pegy <xtpvxt@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #353 (195b29f) into master (f16d434) will decrease coverage by 0.01%.
The diff coverage is 96.72%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   96.39%   96.37%   -0.02%     
==========================================
  Files           9        9              
  Lines         721      773      +52     
==========================================
+ Hits          695      745      +50     
- Misses         26       28       +2     
Impacted Files Coverage Δ
graphene_sqlalchemy/converter.py 96.20% <95.91%> (-0.30%) ⬇️
graphene_sqlalchemy/enums.py 97.80% <100.00%> (ø)
graphene_sqlalchemy/registry.py 100.00% <100.00%> (ø)
graphene_sqlalchemy/utils.py 93.45% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16d434...195b29f. Read the comment docs.

…rs instead of String.

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
erikwrede added 3 commits June 9, 2022 16:42
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
….UUID instead of graphene.String

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
….key instead of Column.name, see graphql-python#330

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
erikwrede added 7 commits June 9, 2022 17:41
Co-authored-by: Nicolas Delaby <nicolas.delaby@infarm.com>
Co-authored-by: davidcim <david@cimaware.com>

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
…valent type names (in most cases)

Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
Signed-off-by: Erik Wrede <erikwrede2@gmail.com>
@erikwrede erikwrede merged commit a702569 into graphql-python:master Jul 15, 2022
@erikwrede erikwrede mentioned this pull request Nov 29, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No UUIDType support

3 participants