Skip to content

allow abstract subclasses of SQLAlchemyObjectType #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

allow abstract subclasses of SQLAlchemyObjectType #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions graphene_sqlalchemy/tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,15 @@ def test_object_type():
assert issubclass(Human, ObjectType)
assert list(Human._meta.fields.keys()) == ['id', 'headline', 'reporter_id', 'reporter', 'pub_date']
assert is_node(Human)


def test_abstract_subclass():
registry = Registry()

class AbstractSubclass(SQLAlchemyObjectType):
class Meta:
registry = registry
abstract = True

assert issubclass(AbstractSubclass, SQLAlchemyObjectType)
assert len(registry._registry) == 0
3 changes: 2 additions & 1 deletion graphene_sqlalchemy/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ class SQLAlchemyObjectTypeMeta(ObjectTypeMeta):
def __new__(cls, name, bases, attrs):
# Also ensure initialization is only performed for subclasses of Model
# (excluding Model class itself).
if not is_base_type(bases, SQLAlchemyObjectTypeMeta):
if not is_base_type(bases, SQLAlchemyObjectTypeMeta) or \
('Meta' in attrs and getattr(attrs['Meta'], 'abstract', False)):
return type.__new__(cls, name, bases, attrs)

options = Options(
Expand Down