Skip to content

Conversation

@aubustou
Copy link
Contributor

If you named your columns with Unicode in Python 2, it obviously won't work...
In order to keep Python 2 and 3 compatibilities, better to use six.string_types.

@coveralls
Copy link

coveralls commented Aug 21, 2019

Coverage Status

Coverage increased (+0.02%) to 97.323% when pulling 59711f4 on aubustou:master into a361c52 on graphql-python:master.

@jnak
Copy link
Collaborator

jnak commented Aug 22, 2019

Makes sense.

It looks like you have a minor lint issue. You should be able to fix it automatically by running tox -e pre-commit (see how to set up your local dev env)

Also would you mind adding or updating a test case to prevent regressions in the future?

Let me know if you run into any issue.
Thanks

@jnak
Copy link
Collaborator

jnak commented Aug 27, 2019

You need to run tox -e pre-commit before pushing your changes. It will re-organize automatically your imports so your tests don't fail.

@aubustou
Copy link
Contributor Author

Once i manage to install that damned Python 3.7 on my install, I'll fix it.

Copy link
Collaborator

@jnak jnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we usually require to add test cases to PR in order to prevent future regressions. But since it's a python 2.7 compatibility fix and Python 2.7 end-of-life is in 4 months, I'm fine merging as is.

Thank you for pushing this PR through!

@jnak jnak merged commit 5eb5559 into graphql-python:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants