Initial implementation of Subscription Docs #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
These look awesome! @nWacky any interest in making sure it matches what you were thinking? |
nWacky
reviewed
Apr 12, 2020
Contributor
nWacky
left a comment
nWacky
left a comment
There was a problem hiding this comment.
Hello. Thank you so much for adding documentation on subscriptions, that looks great.
I'd dive a bit deeper in some topics to help to familiarize people with subscriptions, but the documentation is good even without that
Contributor
Author
|
@nWacky I have added these requested changes into the documentation, thanks for the review. |
LegNeato
approved these changes
Apr 14, 2020
Member
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Approved with some small edits. Thank you so much! We can clean up the rest / fix the links after it lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a advanced topic for Subscriptions in the book and a small example for it without the usage of a web integration. This PR fixes #588.
PR Checklist
Before submitting a PR, you should follow these steps to prevent redundant churn or CI failures: