Make graphql_scalar a proc macro
#610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrisak <andrisak@gmail.com>
LegNeato
requested changes
Apr 10, 2020
Member
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
This is a great start, thank you so much for your hard work!
andrisak
changed the title
graphql_scalar a proc macro #571graphql_scalar a proc macro
Updated documentation. Signed-off-by: andrisak <andrisak@gmail.com>
LegNeato
approved these changes
Apr 20, 2020
Member
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Excellent, thank you so much! I see it still says WIP, is there more to do here or are we good to merge?
andrisak
changed the title
graphql_scalar a proc macrographql_scalar a proc macro
Contributor
Author
|
No, I thinks it's ready to merge now. Fixes #571 |
Member
|
Thank you so much for the high-quality PR! This makes Juniper much easier to use and much more idiomatic 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft implementation of a graphql_scalar proc macro. There are many similarities with the corresponding derive macro and they can probably share a lot of the codegen implementation.