Add subscriptions support on GraphiQL #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses graphql-rust#501 BREAKING CHANGE: `juniper::http::graphiql::graphiql_source` now requires a second parameter BREAKING CHANGE: `juniper_hyper::graphiql` now requires a second parameter BREAKING CHANGE: `juniper_iron::GraphiQLHandler::new` now requires a second parameter BREAKING CHANGE: `juniper_rocket::graphiql_source` now requires a second parameter BREAKING CHANGE: `juniper_warp::graphiql_filter` now requires a second parameter
LegNeato
approved these changes
Apr 13, 2020
Member
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Great, thank you so much for the PR and adding a test! 🍻
jmpunkt
pushed a commit
to jmpunkt/juniper
that referenced
this pull request
Apr 14, 2020
* Add subscriptions support on GraphiQL Addresses graphql-rust#501 BREAKING CHANGE: `juniper::http::graphiql::graphiql_source` now requires a second parameter BREAKING CHANGE: `juniper_hyper::graphiql` now requires a second parameter BREAKING CHANGE: `juniper_iron::GraphiQLHandler::new` now requires a second parameter BREAKING CHANGE: `juniper_rocket::graphiql_source` now requires a second parameter BREAKING CHANGE: `juniper_warp::graphiql_filter` now requires a second parameter * Add test where graphiql subscriptions endpoint is not None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #501
I didn't find a place where this type of stuff is tested. Please let me know if I need to add another test somewhere.
There are a few breaking changes:
BREAKING CHANGE:
juniper::http::graphiql::graphiql_sourcenow requiresa second parameter
BREAKING CHANGE:
juniper_hyper::graphiqlnow requiresa second parameter
BREAKING CHANGE:
juniper_iron::GraphiQLHandler::newnow requiresa second parameter
BREAKING CHANGE:
juniper_rocket::graphiql_sourcenow requiresa second parameter
BREAKING CHANGE:
juniper_warp::graphiql_filternow requiresa second parameter
Here is a gif of it working adapting the example in
examples/warp_subscriptions/src/main.rs.This was done by adding the following lines to
examples/warp_subscriptions/src/main.rs: