Migrate variable tests to internal inspect #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by Node 11.0.0 significant change in output format, see nodejs/node@f4e4ef5cad#diff-c1778ece12049a0e08c6f646c02c10d7R1632 We need to support all LTS versions, so it's better to use our own `inspect` implementation.
IvanGoncharov
force-pushed
the
node11Tests
branch
from
d9b9091 to
bf2a6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by Node 11.0.0 significant change in the output format, see
nodejs/node@f4e4ef5cad#diff-c1778ece12049a0e08c6f646c02c10d7R1632
We need to support all LTS versions, so it's better to use our own
inspectimplementation.