Skip to content

Migrate variable tests to internal inspect #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Migrate variable tests to internal inspect #1573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions src/execution/__tests__/variables-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @noflow
*/

import { inspect } from 'util';
import inspect from '../../jsutils/inspect';
import { expect } from 'chai';
import { describe, it } from 'mocha';
import { execute } from '../execute';
Expand Down Expand Up @@ -81,7 +81,7 @@ function fieldWithInputArg(inputArg) {
args: { input: inputArg },
resolve(_, args) {
if (args.hasOwnProperty('input')) {
return inspect(args.input, { depth: null });
return inspect(args.input);
}
},
};
Expand Down Expand Up @@ -143,7 +143,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ a: 'foo', b: [ 'bar' ], c: 'baz' }",
fieldWithObjectInput: '{ a: "foo", b: ["bar"], c: "baz" }',
},
});
});
Expand All @@ -157,7 +157,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ a: 'foo', b: [ 'bar' ], c: 'baz' }",
fieldWithObjectInput: '{ a: "foo", b: ["bar"], c: "baz" }',
},
});
});
Expand All @@ -171,7 +171,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ a: null, b: null, c: 'C', d: null }",
fieldWithObjectInput: '{ a: null, b: null, c: "C", d: null }',
},
});
});
Expand All @@ -185,7 +185,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ b: [ 'A', null, 'C' ], c: 'C' }",
fieldWithObjectInput: '{ b: ["A", null, "C"], c: "C" }',
},
});
});
Expand Down Expand Up @@ -221,7 +221,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ c: 'foo', d: 'DeserializedValue' }",
fieldWithObjectInput: '{ c: "foo", d: "DeserializedValue" }',
},
});
});
Expand All @@ -240,7 +240,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ a: 'foo', b: [ 'bar' ], c: 'baz' }",
fieldWithObjectInput: '{ a: "foo", b: ["bar"], c: "baz" }',
},
});
});
Expand Down Expand Up @@ -288,7 +288,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ a: 'foo', b: [ 'bar' ], c: 'baz' }",
fieldWithObjectInput: '{ a: "foo", b: ["bar"], c: "baz" }',
},
});
});
Expand All @@ -303,7 +303,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithNullableStringInput: "'Variable value'",
fieldWithNullableStringInput: '"Variable value"',
},
});
});
Expand Down Expand Up @@ -348,7 +348,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ a: 'foo', b: [ 'bar' ], c: 'baz' }",
fieldWithObjectInput: '{ a: "foo", b: ["bar"], c: "baz" }',
},
});
});
Expand All @@ -359,7 +359,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithObjectInput: "{ c: 'foo', d: 'DeserializedValue' }",
fieldWithObjectInput: '{ c: "foo", d: "DeserializedValue" }',
},
});
});
Expand Down Expand Up @@ -475,8 +475,8 @@ describe('Execute: Handles inputs', () => {
null: 'null',
NaN: 'NaN',
false: 'false',
customValue: "'custom value'",
defaultValue: "'DEFAULT_VALUE'",
customValue: '"custom value"',
defaultValue: '"DEFAULT_VALUE"',
},
});
});
Expand Down Expand Up @@ -564,7 +564,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithNullableStringInput: "'a'",
fieldWithNullableStringInput: '"a"',
},
});
});
Expand All @@ -578,7 +578,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithNullableStringInput: "'a'",
fieldWithNullableStringInput: '"a"',
},
});
});
Expand All @@ -594,7 +594,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithNonNullableStringInput: "'default'",
fieldWithNonNullableStringInput: '"default"',
},
});
});
Expand Down Expand Up @@ -646,7 +646,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithNonNullableStringInput: "'a'",
fieldWithNonNullableStringInput: '"a"',
},
});
});
Expand All @@ -660,7 +660,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithNonNullableStringInput: "'a'",
fieldWithNonNullableStringInput: '"a"',
},
});
});
Expand Down Expand Up @@ -754,7 +754,7 @@ describe('Execute: Handles inputs', () => {
`;
const result = executeQuery(doc, { input: ['A'] });

expect(result).to.deep.equal({ data: { list: "[ 'A' ]" } });
expect(result).to.deep.equal({ data: { list: '["A"]' } });
});

it('allows lists to contain null', () => {
Expand All @@ -765,7 +765,7 @@ describe('Execute: Handles inputs', () => {
`;
const result = executeQuery(doc, { input: ['A', null, 'B'] });

expect(result).to.deep.equal({ data: { list: "[ 'A', null, 'B' ]" } });
expect(result).to.deep.equal({ data: { list: '["A", null, "B"]' } });
});

it('does not allow non-null lists to be null', () => {
Expand Down Expand Up @@ -795,7 +795,7 @@ describe('Execute: Handles inputs', () => {
`;
const result = executeQuery(doc, { input: ['A'] });

expect(result).to.deep.equal({ data: { nnList: "[ 'A' ]" } });
expect(result).to.deep.equal({ data: { nnList: '["A"]' } });
});

it('allows non-null lists to contain null', () => {
Expand All @@ -806,7 +806,7 @@ describe('Execute: Handles inputs', () => {
`;
const result = executeQuery(doc, { input: ['A', null, 'B'] });

expect(result).to.deep.equal({ data: { nnList: "[ 'A', null, 'B' ]" } });
expect(result).to.deep.equal({ data: { nnList: '["A", null, "B"]' } });
});

it('allows lists of non-nulls to be null', () => {
Expand All @@ -828,7 +828,7 @@ describe('Execute: Handles inputs', () => {
`;
const result = executeQuery(doc, { input: ['A'] });

expect(result).to.deep.equal({ data: { listNN: "[ 'A' ]" } });
expect(result).to.deep.equal({ data: { listNN: '["A"]' } });
});

it('does not allow lists of non-nulls to contain null', () => {
Expand Down Expand Up @@ -878,7 +878,7 @@ describe('Execute: Handles inputs', () => {
`;
const result = executeQuery(doc, { input: ['A'] });

expect(result).to.deep.equal({ data: { nnListNN: "[ 'A' ]" } });
expect(result).to.deep.equal({ data: { nnListNN: '["A"]' } });
});

it('does not allow non-null lists of non-nulls to contain null', () => {
Expand Down Expand Up @@ -948,7 +948,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithDefaultArgumentValue: "'Hello World'",
fieldWithDefaultArgumentValue: '"Hello World"',
},
});
});
Expand All @@ -962,7 +962,7 @@ describe('Execute: Handles inputs', () => {

expect(result).to.deep.equal({
data: {
fieldWithDefaultArgumentValue: "'Hello World'",
fieldWithDefaultArgumentValue: '"Hello World"',
},
});
});
Expand Down Expand Up @@ -998,7 +998,7 @@ describe('Execute: Handles inputs', () => {
expect(result).to.deep.equal({
data: {
fieldWithNonNullableStringInputAndDefaultArgumentValue:
"'Hello World'",
'"Hello World"',
},
});
});
Expand Down