Skip to content

Omit trailing slash from URLs #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Omit trailing slash from URLs #211

merged 1 commit into from
Jul 24, 2022

Conversation

spawnia
Copy link
Member

@spawnia spawnia commented Jul 24, 2022

If the GitHub link could be updated as well we would be consistent throughout:

image

@ghmcadams ghmcadams merged commit 14b98ea into graphql:main Jul 24, 2022
@benjie
Copy link
Member

benjie commented Jul 25, 2022

Just a note that https://example.com/foo and https://example.com/foo/ are concretely different URLs. Many servers will auto-forward from one to the other, but you cannot assume that this is the case for all URLs. One notable exception to this is the root path https://example.com and https://example.com/ which are equivalent for all websites.

I tested a few of these links and didn't find any that break, but it was not exhaustive.

@ghmcadams
Copy link
Contributor

Thanks for that, @benjie.

@spawnia could you verify that all URLs changed in this PR are still accurate and working? If any are not, we can revert.

@spawnia spawnia deleted the omit-trailing-slash-from-urls branch August 14, 2022 08:55
@spawnia
Copy link
Member Author

spawnia commented Aug 14, 2022

All URLs are fine, except melody.sh which is entirely offline - see #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants