Skip to content

feat(S3UploadPlugin): added ability to pass or calc CacheControl parameter to S3#117

Merged
ValeraS merged 2 commits intomainfrom
feat/pass-cache-control-to-s3-uploader
Jan 24, 2024
Merged

feat(S3UploadPlugin): added ability to pass or calc CacheControl parameter to S3#117
ValeraS merged 2 commits intomainfrom
feat/pass-cache-control-to-s3-uploader

Conversation

@zefirka
Copy link
Copy Markdown
Contributor

@zefirka zefirka commented Jan 17, 2024

No description provided.

@zefirka zefirka requested a review from ValeraS January 17, 2024 11:08
Comment thread src/common/s3-upload/upload.ts Outdated
sourcePath: string;
targetPath?: string;
existsBehavior?: 'overwrite' | 'throw' | 'ignore';
cacheControl?: CdnUploadConfig['cacheControl'];
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an initial type here, and CdnUploadConfig may use UploadOptions['cacheControl']

@ValeraS ValeraS merged commit d2bbb06 into main Jan 24, 2024
@ValeraS ValeraS deleted the feat/pass-cache-control-to-s3-uploader branch January 24, 2024 08:33
@gravity-ui gravity-ui Bot mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants