fix: remove empty targets from lightningcss minimizer#205
Merged
yndx-madfriend merged 2 commits intogravity-ui:mainfrom Mar 20, 2025
Merged
fix: remove empty targets from lightningcss minimizer#205yndx-madfriend merged 2 commits intogravity-ui:mainfrom
yndx-madfriend merged 2 commits intogravity-ui:mainfrom
Conversation
Empty targets list works as "no browser at all": see [how it works](https://lightningcss.dev/playground/index.html#%7B%22minify%22%3Afalse%2C%22customMedia%22%3Atrue%2C%22cssModules%22%3Afalse%2C%22analyzeDependencies%22%3Afalse%2C%22targets%22%3A%7B%7D%2C%22include%22%3A0%2C%22exclude%22%3A0%2C%22source%22%3A%22.foo%20%7B%5Cn%20%20%20%20width%3A%20100%25%3B%5Cn%20%20%20%20width%3A%20stretch%3B%5Cn%20%20%20%20width%3A%20-webkit-fill-available%3B%5Cn%20%20%20%20width%3A%20-moz-available%3B%5Cn%7D%5Cn%22%2C%22visitorEnabled%22%3Afalse%2C%22visitor%22%3A%22%7B%5Cn%20%20Color(color)%20%7B%5Cn%20%20%20%20if%20(color.type%20%3D%3D%3D%20'rgb')%20%7B%5Cn%20%20%20%20%20%20color.g%20%3D%200%3B%5Cn%20%20%20%20%20%20return%20color%3B%5Cn%20%20%20%20%7D%5Cn%20%20%7D%5Cn%7D%22%2C%22unusedSymbols%22%3A%5B%5D%2C%22version%22%3A%22local%22%7D) for multiple width declarations.
dgaponov
approved these changes
Mar 14, 2025
dgaponov
changed the title
Contributor
Author
Contributor
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty targets list works as "no browser at all": see how it works for multiple width declarations.