feat: support React 19 in peerDependencies#393
Merged
Conversation
- Extend react/react-dom peers with ^19.0.0 - Widen RefObject<T> to RefObject<T | null> in public/internal ref typings for compatibility with @types/react@19 - Replace JSX.Element with React.ReactElement in public types
Contributor
|
Preview is ready. |
amje
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react/react-dompeerDependencieswith^19.0.0(keeping 16/17/18).RefObject<T>→RefObject<T | null>) in public and internal types so consumers on@types/react@19get clean type-checking —useRef<T>(null)returnsRefObject<T | null>in v19. Backward-compatible with@types/react@18(covariant assignment).JSX.ElementwithReact.ReactElementinNotificationspublic types —@types/react@19removed the globalJSXnamespace.<button ref>and TokenizedInput Wrapper's native<div ref>) needed for@types/react@18LegacyRef<T>variance — commented inline.devDependenciesare intentionally not bumped —react/react-dom/@types/react/@types/react-domstay on^18, matching the approach used in@gravity-ui/uikit. The library is verified against React 19 ad-hoc (see test plan); the dev stack continues to develop and test against React 18.