feat: add destroyOnUnregister property #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
bocembocem
requested changes
Jul 1, 2024
| } | ||
| }; | ||
| }, []); | ||
| }, [destroyOnUnregister]); |
Collaborator
There was a problem hiding this comment.
here this flag should not cause an effect, its value will be relevant in the callback, this is the main thing that we need
Contributor
Author
There was a problem hiding this comment.
Its value will be relevant in the callback
I don't think so, on "unmount" it will have the first value provided in this case, and it will be not updated on prop change.
But generally, yes, the "logic part" shouldn't be triggered by its value change. And most likely it won't be changed.
Collaborator
There was a problem hiding this comment.
I don't think so, on "unmount" it will have the first value provided in this case, and it will be not updated on prop change.
Oh, you're right, we'll have to go back to this place and make the flag and store.name the callback was relevant
bocembocem
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, dynamic forms clear the final form field value on unmount. This should be configurable. The name of the property and its description comes from the final form docs