fix(camera): don't apply PAN_SPEED to pointer drag#295
Merged
Antamansid merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the PAN_SPEED multiplier from pointer-drag camera movement so that drag panning tracks the cursor 1:1, while keeping PAN_SPEED semantics for wheel/trackpad swipe and updating the PAN_SPEED documentation accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Preview is ready. |
draedful
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PAN_SPEEDwas applied to both the wheel-driven trackpad swipe (handleTrackpadMove) and the pointer drag (onDragUpdate). Pointer drag covers two cases:In both cases the delta passed to
camera.move()is the literal cursor displacement (event.pageX - lastDragEvent.pageX). Multiplying it byPAN_SPEED > 1makes the canvas slide out from under the pointer — the cursor and the grabbed point stop tracking 1:1.Two-finger trackpad swipes go through
wheelevents with abstractdeltaX/deltaYunits, so a multiplier there is meaningful and stays.Fix
Camera.onDragUpdate: drop thePAN_SPEEDmultiplier; pointer drag now tracks the cursor 1:1 regardless ofPAN_SPEED.handleTrackpadMove: unchanged — still scales wheel deltas byPAN_SPEED.PAN_SPEEDJSDoc ingraphConfig.tsto reflect the new semantics (trackpad swipe / wheel scroll only, not pointer drag).Summary by Sourcery
Ensure camera pointer drag pans the scene 1:1 with cursor movement instead of being affected by the configurable pan speed multiplier.
Bug Fixes:
Documentation: