fix(Media): support boolean and parameterized loop for both video types #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mournfulCoroner
requested review from
NikitaCG and
aeksandla
as code owners
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
NikitaCG
requested changes
Sep 26, 2025
| "loop": { | ||
| "start": 0 | ||
| }, | ||
| "loop": true, |
Collaborator
There was a problem hiding this comment.
maybe you need to add new part of data for new story ?
| } | ||
|
|
||
| if (loop) { | ||
| videoElement.currentTime = 0; |
Collaborator
There was a problem hiding this comment.
but if there is still a loop: {start: 10} ? then shouldn't it be 0?
mournfulCoroner
changed the title
mournfulCoroner
force-pushed
the
fix-support-bolean-loop-for-default-video
branch
from
8416f10 to
a3f9edc
Compare
NikitaCG
approved these changes
Oct 1, 2025
aeksandla
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified fix instead #1287
Closes #1286