fix(DefaultVideo): fix loop prop #1287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
NikitaCG
requested changes
Sep 15, 2025
| customControlsOptions, | ||
| muted: initiallyMuted = true, | ||
| onVideoEnd, | ||
| loop, |
Collaborator
There was a problem hiding this comment.
we won't get a conflict with this logic ? https://github.com/gravity-ui/page-constructor/blob/main/src/components/Media/Video/Video.tsx#L49
when rendering from the Video file, you need to check that loop is a boolean, and if it is a parameter, then you don't need to include it in defaultVideo
Contributor
|
fix in #1298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1286