Skip to content

Conversation

@arteria32
Copy link
Contributor

Test example for YMap
Screenshot 2025-11-13 at 19 50 45
Test example for Google Map
Screenshot 2025-11-13 at 19 51 14

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@arteria32 arteria32 marked this pull request as ready for review November 13, 2025 17:12
itemType={GeoCoordinatesMicrodataValues.PlaceType}
>
{address && (
<meta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key={marker.address ?? marker.coordinate.join(',') ?? index}
>
<meta
itemProp={GeoCoordinatesMicrodataValues.LongitudeProp}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I understand correctly that you want to allow the user to specify additional data for microdata ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
I suggest writing a microdata in a different format so as not to clog up the code. JSON-LD looks more compact.

<script type="application/ld+json" dangerouslySetInnerHTML={{__html: {write microdata values there}}} />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I agree. Push changes a little bit later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@arteria32 arteria32 merged commit 40b079a into gravity-ui:main Nov 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants