feat: add whitelist of image extenstions which can be compressed #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
NikitaCG
reviewed
Mar 14, 2023
src/utils/imageCompress.ts
Outdated
| @@ -0,0 +1,8 @@ | |||
| export enum AvailableForCompressExtention { | |||
NikitaCG
reviewed
Mar 14, 2023
src/utils/imageCompress.ts
Outdated
| } | ||
|
|
||
| export const canBeCompressed = (fileName: string) => | ||
| Object.keys(AvailableForCompressExtention).find((ext) => fileName.endsWith(`.${ext}`)); |
Collaborator
There was a problem hiding this comment.
.some work similarly like .find, but always return boolean. If we need boolean in disableWebp variable always, we need to use .some
NikitaCG
approved these changes
Mar 17, 2023
yuberdysheva
suggested changes
Mar 23, 2023
niktverd
force-pushed
the
feat/disable_compress
branch
from
8493a2b to
7f284cd
Compare
yuberdysheva
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.