feat: map-block parameter for disable auto zoom #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
gorgeousvlad
approved these changes
Mar 17, 2023
Lakate
force-pushed
the
lakate/map-disable-auto-zoom
branch
from
d3fce83 to
decb3f9
Compare
Contributor
Author
|
Some changes:
|
gorgeousvlad
suggested changes
Mar 22, 2023
src/components/Map/GoogleMap.tsx
Outdated
| scriptSrc: string, | ||
| address: string, | ||
| lang: 'ru' | 'en', | ||
| zoom?: number, |
Contributor
There was a problem hiding this comment.
to many serial params in function let's rewrite to object
src/components/Map/GoogleMap.tsx
Outdated
| apiKey: string, | ||
| scriptSrc: string, | ||
| address: string, | ||
| lang: 'ru' | 'en', |
Contributor
There was a problem hiding this comment.
do we already had enum for Lang?
src/components/Map/Map.scss
Outdated
| overflow: hidden; | ||
| display: flex; | ||
|
|
||
| &_visible_no { |
Contributor
There was a problem hiding this comment.
can we replace visible_no to hidden?
src/components/Map/YMap/YMap.ts
Outdated
| private recalcZoomAndCenter() { | ||
| private recalcZoomAndCenter(props: PlacemarksProps) { | ||
| const coordsLength = this.coords.length; | ||
| const {zoom} = props; |
Contributor
There was a problem hiding this comment.
const {zoom=0} = props;
|
|
||
| if (zoom) { | ||
| // compute only the center | ||
| newMapParams.center = window.ymaps.util.bounds.getCenter([leftBottom, rightTop]); |
Contributor
There was a problem hiding this comment.
can we get the situation when window.ymaps or window.ymaps.util or window.ymaps.util.bounds is undefined?
Contributor
Author
There was a problem hiding this comment.
- we create new Map after getting window.ymaps => we get to this place after getting window.ymaps
- util and util.bounds are always available
| const b = block('map'); | ||
| const DEFAULT_CONTAINER_ID = 'ymap'; | ||
| const DEFAULT_ZOOM = 9; | ||
| const DEFAULT_CENTER = [55.755864, 37.617698]; // will be calculated later |
Contributor
There was a problem hiding this comment.
did't understand meaning of the comment
| {/* visible - to show the map after calculating the center */} | ||
| <div | ||
| id={containerId} | ||
| className={b({visible: ready ? 'yes' : 'no'})} |
Contributor
There was a problem hiding this comment.
className={b({hidden: !Boolean(ready)})}
Lakate
force-pushed
the
lakate/map-disable-auto-zoom
branch
from
decb3f9 to
6f69963
Compare
Lakate
force-pushed
the
lakate/map-disable-auto-zoom
branch
from
6f69963 to
23de6cf
Compare
gorgeousvlad
approved these changes
Mar 23, 2023
niktverd
pushed a commit
that referenced
this pull request
Mar 24, 2023
niktverd
pushed a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.