feat: add passive flag and alt to img #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
yuberdysheva
suggested changes
Apr 21, 2023
Contributor
yuberdysheva
left a comment
yuberdysheva
left a comment
There was a problem hiding this comment.
I'm not sure about where we should storage names of frames and alts, maybe it has to be some i18n or variables? I want to check it with @gorgeousvlad
src/components/Image/Image.tsx
Outdated
| const { | ||
| src, | ||
| alt, | ||
| alt = 'image alt', |
Contributor
There was a problem hiding this comment.
Maybe we have to name alt consistent? I saw names started with Capital letters and this one starts with lowercase letter
Contributor
Author
There was a problem hiding this comment.
done, Capital letter
…ravity-ui/page-constructor into add_alt_image_and_passive_flag
VitaliiDC8
force-pushed
the
add_alt_image_and_passive_flag
branch
from
389ab7a to
8498fe6
Compare
yuberdysheva
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.