feat: remove block header, add title #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
yuberdysheva
force-pushed
the
yuberdysheva/block-header-refactoring
branch
from
1306298 to
9fb2ba2
Compare
aeksandla
reviewed
May 19, 2023
| `type: "title"` | ||
|
|
||
| `text: text` — Title text | ||
| `title:` |
Collaborator
There was a problem hiding this comment.
should there be a description of the prop here?
Contributor
Author
There was a problem hiding this comment.
It is in the line 13.
Or you mean the title himself?
It's an object with properties below
- text
- textSize
- url
- resetMargin
aeksandla
previously approved these changes
May 22, 2023
gorgeousvlad
suggested changes
May 23, 2023
| return ( | ||
| <AnimateBlock className={b()} animate={animated}> | ||
| <BlockHeader title={title} description={description} className={b('header')} /> | ||
| <Title title={title} description={description} className={b('header')} /> |
Contributor
There was a problem hiding this comment.
is it strange that component Title has property title?) Whole component is title
Or in this case description should became subtitle may be
Contributor
Author
There was a problem hiding this comment.
I renamed description to subtitle
src/components/Title/TitleItem.tsx
Outdated
| resetMargin?: boolean; | ||
| } | ||
|
|
||
| const Title = (props: TitleItemFullProps) => { |
src/sub-blocks/Content/Content.tsx
Outdated
| return ( | ||
| <Col className={b({size, centered, theme}, className)} reset sizes={colSizes}> | ||
| {title && <Title className={b('title')} {...titleProps} resetMargin />} | ||
| {title && <Title className={b('title')} title={{...titleProps}} colSizes={{all: 12}} />} |
src/sub-blocks/Content/Content.tsx
Outdated
| ? ({text: title, textSize: getTextSize(size)} as TitleProps) | ||
| : title; | ||
| ? ({text: title, textSize: getTextSize(size), resetMargin: true} as TitleItemProps) | ||
| : {...title, resetMargin: true}; |
Contributor
There was a problem hiding this comment.
resetMargin is true by default in TitleItem
gorgeousvlad
approved these changes
May 24, 2023
yuberdysheva
pushed a commit
that referenced
this pull request
May 26, 2023
yuberdysheva
pushed a commit
that referenced
this pull request
May 31, 2023
yuberdysheva
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.