feat: add editor forms #393
Conversation
gorgeousvlad
force-pushed
the
add-editor-forms
branch
from
0593b69 to
54eaf41
Compare
|
Preview is ready. |
| type: 'string', | ||
| enum: ['events', 'blog', 'services'], | ||
| // add loadable sources here if you use it in your project | ||
| // enum: ['my-loadable-source-1', 'my-loadable-source-1'], |
There was a problem hiding this comment.
it seems to me not very obvious how to add, can we leave an example?
There was a problem hiding this comment.
yes, it needs a story for slider, created a ticket for it
| const Icon = editBlockControlsIcons[action]; | ||
|
|
||
| return actions[action] ? ( | ||
| <div className={b('control')} onClick={actions[action]}> |
There was a problem hiding this comment.
maybe we need to add key ?
| injectEditBlockProps, | ||
| } = useEditorState(rest); | ||
| const constructorProps = useMemo(() => { | ||
| return { |
There was a problem hiding this comment.
maybe () => ({ .... }) return object immediately ?
src/editor/containers/Form/Form.tsx
Outdated
| blocks: [...blocks.slice(0, index), data, ...blocks.slice(index + 1)], | ||
| }); | ||
| }} | ||
| onSelect={() => onSelect(index)} |
There was a problem hiding this comment.
We can use useCallback when we render callback in every list item. Cases for onChange and onSelect
There was a problem hiding this comment.
there is the problem with useCallback, because both of this functions use index param from closure of mapping function
src/editor/containers/Form/Form.tsx
Outdated
| const blocks = content?.blocks || []; | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Are we can use <Fragment> in this place ?
| //getting oneOf option type from initial value | ||
| const valueType = useMemo( | ||
| () => | ||
| (props.spec?.properties && |
There was a problem hiding this comment.
it seems to me it is necessary to use destructurization for props, in the whole file
| const getOneOfCsutomSpecDefaultType = (spec: ObjectSpec) => | ||
| spec.viewSpec?.order?.[0] || Object.keys(spec.properties || {})[0]; | ||
|
|
||
| export const OneOfCustom: React.FC<ObjectIndependentInputProps> = (props) => { |
There was a problem hiding this comment.
it's not immediately clear what kind of component, can we add some comments?
| disabled={disabled} | ||
| qa={name} | ||
| > | ||
| {options.map((option) => ( |
src/editor/dynamic-forms-custom/components/OneOfCustom/OneOfCustom.scss
Outdated
Show resolved
Hide resolved
src/editor/dynamic-forms-custom/components/OneOfCustom/OneOfCustom.tsx
Outdated
Show resolved
Hide resolved
src/editor/dynamic-forms-custom/components/OneOfCustom/OneOfCustom.tsx
Outdated
Show resolved
Hide resolved
No description provided.