feat: add editor mode switch #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorgeousvlad
changed the title
Contributor
|
Preview is ready. |
NikitaCG
reviewed
Jun 15, 2023
| $buttonIconSize: 16px; | ||
| $buttonWidth: 76px; | ||
| $buttonHeight: 40px; | ||
| $zIndex: 110; |
Collaborator
There was a problem hiding this comment.
up to you, but if we use this variable one time, maybe we dont need this variable ?
NikitaCG
reviewed
Jun 15, 2023
| onViewModeChange, | ||
| className, | ||
| }: ControlPanelProps) => { | ||
| return ( |
NikitaCG
reviewed
Jun 15, 2023
NikitaCG
reviewed
Jun 15, 2023
| if (isEditingMode) { | ||
| return { | ||
| content, | ||
| custom: addCustomDecorator( |
Collaborator
There was a problem hiding this comment.
maybe refactor like this:
{
....
const customProp = isEditingMode ? ... : rest.custom;
...
return {content, custom: customProp};
}
NikitaCG
reviewed
Jun 15, 2023
src/editor/hooks/usePrevious.ts
Outdated
| @@ -0,0 +1,11 @@ | |||
| import {useEffect, useRef} from 'react'; | |||
|
|
|||
| export default function usePrevious<T>(value: T) { | |||
Collaborator
There was a problem hiding this comment.
if we use this hook to save previous value, i think we need named this hook like usePreviousValue, because it's not obvious what the previous entity is
yuberdysheva
previously approved these changes
Jun 15, 2023
NikitaCG
approved these changes
Jun 16, 2023
yuberdysheva
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.