feat: yaml tab in editor (read-only) #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
NikitaCG
requested changes
Jul 24, 2023
yuberdysheva
previously approved these changes
Jul 24, 2023
NikitaCG
previously approved these changes
Jul 24, 2023
gorgeousvlad
suggested changes
Jul 25, 2023
|
|
||
| export const YamlEditor = ({content}: YamlEditorProps) => ( | ||
| <MonacoEditor | ||
| value={yaml.dump(content)} |
| <MonacoEditor | ||
| value={yaml.dump(content)} | ||
| language="yaml" | ||
| options={{ |
Contributor
There was a problem hiding this comment.
probably for options too
Contributor
Author
There was a problem hiding this comment.
also wrapped with useMemo
Contributor
Author
|
Also added copy button |
gorgeousvlad
suggested changes
Jul 26, 2023
| @@ -0,0 +1,42 @@ | |||
| import React, {useState} from 'react'; | |||
Contributor
There was a problem hiding this comment.
Could we use ClipboardButton from uikit instead?
Contributor
Author
There was a problem hiding this comment.
Yes, we could. Should look for it first
gorgeousvlad
previously approved these changes
Jul 26, 2023
added 11 commits
July 31, 2023 16:01
gorgeousvlad
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.