-
Notifications
You must be signed in to change notification settings - Fork 23
feat(Image): add hide param #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Playwright Test Component is ready. |
|
Preview is ready. |
e576511 to
258a018
Compare
| return ( | ||
| <picture className={containerClassName} data-qa={qa}> | ||
| {mobile && ( | ||
| {(mobile || hideDevices.mobile) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if hideDevices.mobile === true I think we don't need render this block, but It's the opposite now
maybe we need to change name for hideDevices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We show this block when the picture in mobile is hidden to show an empty picture. If you do not show this block when the hideDevices.mobile === true parameter, a desktop or tablet image will be installed on the mobile resolution.
| qa={qaAttributes.tabletSource} | ||
| /> | ||
| )} | ||
| {hideDevices.desktop && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where case for hideDevices is boolean true ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 135 it says that an empty picture is displayed here. If the image on the desktop is hidden, then we show an empty picture.
No description provided.