Skip to content

Conversation

@aeksandla
Copy link
Collaborator

No description provided.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@aeksandla aeksandla force-pushed the aeksandla/hide-image branch from e576511 to 258a018 Compare May 16, 2025 14:29
@aeksandla aeksandla marked this pull request as ready for review May 16, 2025 14:35
@aeksandla aeksandla requested a review from NikitaCG as a code owner May 16, 2025 14:35
return (
<picture className={containerClassName} data-qa={qa}>
{mobile && (
{(mobile || hideDevices.mobile) && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if hideDevices.mobile === true I think we don't need render this block, but It's the opposite now
maybe we need to change name for hideDevices

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We show this block when the picture in mobile is hidden to show an empty picture. If you do not show this block when the hideDevices.mobile === true parameter, a desktop or tablet image will be installed on the mobile resolution.

qa={qaAttributes.tabletSource}
/>
)}
{hideDevices.desktop && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where case for hideDevices is boolean true ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 135 it says that an empty picture is displayed here. If the image on the desktop is hidden, then we show an empty picture.

@aeksandla aeksandla merged commit 1b969a2 into main May 20, 2025
4 checks passed
@aeksandla aeksandla deleted the aeksandla/hide-image branch May 20, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants