chore(Share): update storybook #1322
Merged
+30
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
aeksandla
requested changes
Nov 11, 2025
| title: 'Blocks/Share', | ||
| argTypes: { | ||
| title: { | ||
| control: {type: 'text'}, |
Collaborator
There was a problem hiding this comment.
Let's make sure that these controls are pulled up automatically. If they did not appear automatically, it is possible that this is due to Pick<>, different names of the file and the component in the file.
Contributor
Author
There was a problem hiding this comment.
Deleted title from argTypes, but left for items because it looks better with control type: 'check'
|
|
||
| const DefaultTemplate: StoryFn<ShareBLockModel> = (args) => ( | ||
| <PageConstructor content={{blocks: [args]}} /> | ||
| <PageConstructor content={{blocks: [blockTransform(args)]}} /> |
Collaborator
There was a problem hiding this comment.
Let's remove the PageConstructor here and just make a Share component. Most likely, this will fix the problem with the controls.
Contributor
Author
There was a problem hiding this comment.
Removed PageConstructor
This was referenced Nov 11, 2025
lentsd
force-pushed
the
chore/update-share-storybook
branch
from
f21b025 to
c092e24
Compare
lentsd
force-pushed
the
chore/update-share-storybook
branch
from
c092e24 to
e1965bc
Compare
aeksandla
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Share block story for better storybook ux