Skip to content

fix: enable first column resize#43

Merged
artemmufazalov merged 1 commit intomainfrom
fix-first-column-resize
May 6, 2024
Merged

fix: enable first column resize#43
artemmufazalov merged 1 commit intomainfrom
fix-first-column-resize

Conversation

@artemmufazalov
Copy link
Copy Markdown
Contributor

No description provided.

@gravity-ui-bot
Copy link
Copy Markdown
Contributor

Preview is ready.

Comment thread src/lib/DataTable.tsx
};
};
_getRenderedColumn = (index?: number) => {
if (index) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this condition was false for the first column, so resize for this column didn't work

Comment thread src/lib/useTableResize.ts
export function updateColumnsWidth<T>(
columns: Column<T>[],
columnsWidthSetup: ColumnWidthByName,
defaultResizeable = false,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded parameter

@artemmufazalov artemmufazalov marked this pull request as ready for review May 6, 2024 13:47
@artemmufazalov artemmufazalov requested a review from ma-efremoff May 6, 2024 13:47
@artemmufazalov artemmufazalov merged commit 659541d into main May 6, 2024
@artemmufazalov artemmufazalov deleted the fix-first-column-resize branch May 6, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants