Fix notification create command #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: HS#303986
This fixes some issues with the docblock for the notification create command, the main being that the synopsis is for a different command so using the
--notification-jsonoption resulted in a parameter error.Once the synopsis was fixed I noticed that the form id was assigned as the notification name instead of the value provided for the
nameoption. This was fixed by getting the value from$args[1]instead of$args[0].Testing Instructions
wp gf form notification create 1 'the name' --notification-json='{"subject":"the subject","message":"the message","from":"{admin_email}","fromName":"the from name"}'replacing1with the ID of your test form