Skip to content

Conversation

@richardW8k
Copy link
Member

re: HS#303986

This fixes some issues with the docblock for the notification create command, the main being that the synopsis is for a different command so using the --notification-json option resulted in a parameter error.

Once the synopsis was fixed I noticed that the form id was assigned as the notification name instead of the value provided for the name option. This was fixed by getting the value from $args[1] instead of $args[0].

Testing Instructions

  • With master enter wp gf form notification create 1 'the name' --notification-json='{"subject":"the subject","message":"the message","from":"{admin_email}","fromName":"the from name"}' replacing 1 with the ID of your test form
  • Find a parameter error occurs
  • Switch to this branch
  • Repeat command
  • Find notification is created and "the name" is assigned as the name of the notification

@richardW8k richardW8k added the bug label Jul 17, 2020
@richardW8k richardW8k requested a review from karlpotter July 17, 2020 07:59
@richardW8k richardW8k merged commit 12ce23e into master Jul 20, 2020
@richardW8k richardW8k deleted the fix-notification-create branch July 20, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants