Skip to content

Fix fatal error which can occur when using the version command with an add-on slug #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fix fatal error which can occur when using the version command with an add-on slug #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbea469
Fix fatal error when using add-on slug
richardW8k Aug 4, 2020
77cff5c
update change log
richardW8k Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions change_log.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
= 1.3.1 =
- Added support for using `--version=beta` with the `wp gf install` and `wp gf update` commands. Add-On beta releases are not currently supported.
- Fixed a fatal error which can occur when using the `wp gf version` command with an add-on slug when Gravity Forms is not active or not installed.

= 1.3 =
- Fixed an error occurring when using the `wp gf form notification create` command.
Expand Down
10 changes: 5 additions & 5 deletions includes/class-gf-cli-root.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ class GF_CLI_Root extends WP_CLI_Command {
* wp gf version gravityformspolls
*/
public function version( $args, $assoc_args ) {
if ( ! class_exists( 'GFForms' ) ) {
WP_CLI::error( 'Gravity Forms is not installed. Use the wp gf install command.' );
}

$slug = $this->get_slug( $args );

if ( $slug == 'gravityforms' ) {
if ( class_exists( 'GFForms' ) ) {
WP_CLI::log( GFForms::$version );
} else {
WP_CLI::error( 'Gravity Forms is not installed. Use the wp gf install command.' );
}
WP_CLI::log( GFForms::$version );
} else {
$addon_class_names = GFAddOn::get_registered_addons();
$addon_found = false;
Expand Down
1 change: 1 addition & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ If you have any ideas for improvements please submit your idea at https://www.gr

= 1.3.1 =
- Added support for using `--version=beta` with the `wp gf install` and `wp gf update` commands. Add-On beta releases are not currently supported.
- Fixed a fatal error which can occur when using the `wp gf version` command with an add-on slug when Gravity Forms is not active or not installed.

= 1.3 =
- Fixed an error occurring when using the `wp gf form notification create` command.
Expand Down