Update type to wordpress-plugin

[SherifMesallam]

Description

This PR fixes gravityforms/backlog#386 by updating the package type to wordpress-plugin

Testing Instructions

1. Outside of your WordPress installation, in another directory, create a composer.json file with the following contents:

{
	"repositories": [
		{
			"type": "git",
			"url": "git@github.com:gravityforms/gravityformscli.git"
		}
	],
	"require": {
		"composer/installers": "^1.11",
		"gravityforms/gravityformscli": "^1.4"
	}
}

2. Run composer install.
3. Review the contents of the directory. You should see a composer.lock file and a vendor directory. The vendor directory should contain a directory named gravityforms, which itself contains a directory named gravityformscli, which contains the contents of this repository.
4. Run rm --rf vendor composer.lock in the command line.
5. Run composer require gravityforms/gravityformscli:dev-fix-386-package-type.
6. Review your directory contents again. You should now have a vendor directory and a wp-content directory. The wp-content directory should contain the gravityformscli package within the plugins directory.

[SherifMesallam]

@jmichaelward not sure how to write the testing instructions for this one?

[jmichaelward]

@jmichaelward not sure how to write the testing instructions for this one?

I messaged you in Slack about this, but letting you know here, too, that I added testing instructions above.

[jmichaelward]

It's unclear whether we need a version bump right now, but I'd assume not and that this is probably just an administrative change that will go out with the next release.

[michelle-bauer]

I ran into an error while running composer install. Maybe I could pair with someone tomorrow to test this?

[jmichaelward]

I ran into an error while running composer install. Maybe I could pair with someone tomorrow to test this?

@michelle-bauer I can help walk you through it. My assumption is that you don't have an SSH key attached to your GitHub account, so the git@github.com URL in the composer.json file doesn't work for you (because our repositories are private). We can approach it a couple of different ways: walk through the process of getting you set up with an SSH key (so you can test similar stuff like this in the future), do a screenshare where show you how it works, or we can update the composer.json file to point to your local file system instead of the GitHub repo, just for the purposes of demonstrating the difference between a wordpress-plugin type package and a package type.

[michelle-bauer]

@jmichaelward I may just be doing it wrong. Here's the error I am getting: Fatal error: Uncaught ArgumentCountError: array_merge() does not accept unknown named parameters in phar:///Applications/Local.app/Contents/Resources/extraResources/bin/composer/composer.phar/src/Composer/DependencyResolver/DefaultPolicy.php:84

I'd love to walk through the testing steps together in the am.

[SherifMesallam]

It's unclear whether we need a version bump right now, but I'd assume not and that this is probably just an administrative change that will go out with the next release.

Agreed.

[SherifMesallam]

@jmichaelward I may just be doing it wrong. Here's the error I am getting: Fatal error: Uncaught ArgumentCountError: array_merge() does not accept unknown named parameters in phar:///Applications/Local.app/Contents/Resources/extraResources/bin/composer/composer.phar/src/Composer/DependencyResolver/DefaultPolicy.php:84

I'd love to walk through the testing steps together in the am.

Hi @michelle-bauer I think this has something to do with the PHP version, are you using 8 ?

You can try updating composer, first try
composer self-update --stable
If that didn't workout, try
composer self-update --snapshot

Happy to have a call anytime to go through it together

[michelle-bauer]

Ah, that worked! Thanks, Sherif! 🎉