Skip to content

Fix/hs4608 #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zackkatz merged 4 commits into from
Feb 3, 2016
Merged

Fix/hs4608 #614

zackkatz merged 4 commits into from
Feb 3, 2016

Conversation

@luistinygod
Copy link

@luistinygod luistinygod commented Jan 22, 2016 •
edited by zackkatz
Loading

Fixed: When sorting recent entries disappeared from the view.

  • Don't set $search_criteria['start_date'] if start_date is empty as it may lead to bad query results (GFAPI::get_entries)
  • Remove [mode] if no fields filters are added

These two changes may prevent issues in the future.

┆Issue is synchronized with this Asana task

zackkatz added a commit that referenced this pull request Feb 3, 2016
@zackkatz
Merge pull request #614 from gravityview/fix/hs4608
9a7ed8a 
Fix/hs4608
@zackkatz zackkatz merged commit 9a7ed8a into develop Feb 3, 2016
@zackkatz zackkatz deleted the fix/hs4608 branch February 3, 2016 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luistinygod @zackkatz