Skip to content

Conversation

@veryspry
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/3029373412/87530?viewId=14962

Summary

Adds GPT-5 series models for GC OpenAI.

Also updates the deprecated max_tokens parameter to max_completion_tokens. It's worth noting that GPT-5 series models will actually return an error if max_tokens is used instead of max_completion_tokens.

@veryspry
Copy link
Contributor Author

veryspry commented Aug 18, 2025

This one is waiting on the GCOAI changes so that they get released simultaneously.

@veryspry veryspry marked this pull request as draft August 19, 2025 21:40
@veryspry veryspry marked this pull request as ready for review August 26, 2025 17:18
public function get_openai_models() {
$models = array(
'chat/completions' => array(
'gpt-4o' => array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like gpt-4o is missing from the updating list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (amended my first commit)

Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

S&M with

Added support for `gpt-5`, `gpt-5-mini`, and `gpt-5-nano` Chat Completions models.

@veryspry veryspry merged commit 155a52c into master Aug 27, 2025
1 of 2 checks passed
@veryspry veryspry deleted the matt/gpt-5 branch August 27, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants