gwaft-template-collapsible.php: Fixed an issue with page numbers and hidden fields.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2849211669/78114

Summary

The collapsible templates snippet does not work because the values of $page_groups and $pages are an "index" behind.

Adjustment for the index issue, and adding a field visibility check.

BEFORE Customer described issue (was also reproduced locally with a simple form):
https://app.screencast.com/wVMGdfNrt8gY2

AFTER the snippet update:
https://www.loom.com/share/457a4df1ae314b92a54e5f18b3e7ad71

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against f170d3a

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

[claygriffiths]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes modify the processing of the $data['items'] within the gravity-forms/gwaft-template-collapsible.php file. The updated logic skips fields marked as hidden—either by type or by visibility—and adjusts the pageNumber to be zero-based before grouping visible fields.

Changes

File	Change Summary
gravity-forms/gwaft-template-collapsible.php	Filters out hidden fields by checking if the field type is "hidden" or its visibility is "hidden". Adjusts the pageNumber to zero-based (subtracting 1) before grouping.

Sequence Diagram(s)

sequenceDiagram
    participant F as Function
    participant I as Items Array
    participant G as Grouping Logic

    F->>I: Start loop over $data['items']
    I-->>F: Return field item
    F->>F: Check if field type/visibility equals "hidden"
    alt Field is hidden
        F-->>F: Skip current iteration (continue)
    else Field is visible
        F->>F: Adjust pageNumber (pageNumber - 1)
        F->>G: Add field to corresponding page group
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f170d3a and 6467836.

📒 Files selected for processing (1)

• gravity-forms/gwaft-template-collapsible.php (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[veryspry]

I left one suggested change, but am approving anyways since I'm OOO the next few days. Don't want to hold a snippet up for a nitpick 🙂