gw-prevent-duplicate-submissions.php: Fixed a compatibility issue with jQuery.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/3129176410/92224

Summary

The snippet is generating a JS error in the browser console, which is also affecting other perks like GP Nested Forms.

Uncaught ReferenceError: jQuery is not defined

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The initialization code in the Gravity Forms duplicate submission prevention plugin was refactored from a jQuery DOMReady wrapper to a native DOMContentLoaded event listener with a jQuery presence guard. The submit-button handling logic remains nested under the initialization path, and a call to hasPendingFileUploads now passes formId as an argument, though the function declaration lacks parameters.

Changes

Cohort / File(s)	Summary
Initialization refactoring gravity-forms/gw-prevent-duplicate-submissions.php	Replaced jQuery DOMReady wrapper with DOMContentLoaded listener and jQuery guard; nested submit-button handling logic under new initialization path; updated hasPendingFileUploads call with formId argument; restructured CSS changes for button hiding behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Function signature mismatch: The hasPendingFileUploads call now passes formId as an argument, but the function declaration remains parameterless. Verification needed to confirm this is intentional or requires a fix.
• jQuery guard implementation: Ensure the jQuery presence check correctly handles environments without jQuery and doesn't inadvertently break existing functionality.
• Event timing: Verify that DOMContentLoaded is the appropriate trigger point and doesn't introduce race conditions with dependent scripts or DOM state.

Suggested reviewers

• veryspry

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch saif/fix/92224-fix-jquery-issue

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08fd034 and 955f8f0.

📒 Files selected for processing (1)

• gravity-forms/gw-prevent-duplicate-submissions.php (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}