Skip to content

Conversation

@sbassah
Copy link
Contributor

@sbassah sbassah commented Feb 27, 2023

Context

This snippet replaces the space separator when using the phone[nationalNumberFormatted] modifier.

Ticket: https://secure.helpscout.net/conversation/2164492172/44662?folderId=3775888

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

Fails
🚫 Please include a description of your PR changes so our future selves are thankful of our past selves. 😃
Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against b541704

@sbassah sbassah requested a review from spivurno February 27, 2023 15:50
Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

I went ahead and removed the plugin header since this is a snippet that is unlikely to be installed as a plugin and having a smaller header makes the snippet easier to read and modify.

@spivurno spivurno merged commit 2ae6f9b into master Jan 10, 2025
@spivurno spivurno deleted the samuel/add/replace-space-seperator branch January 10, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants