gpaa-single-line-as-input.php: Added full address capability to the Single Line as Input functionality.
#758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Single Line as Input functionality.
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
Looks fine to me! I have a couple of suggestions to help clarify things for users and future us.
… Single Line as Input functionality.
… Single Line as Input functionality.
… Single Line as Input functionality.
|
Contributor
Author
|
PR updated: #818 |
saifsultanc
deleted the
saif/fix/59879-add-full-address-to-single-line-as-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2478783845/59879?folderId=7098280
Summary
Use full street address snippet cannot be directly used with the current Single Line as Input snippet. This update adds an extra argument to the Single Line as Input
use_full_addressand the internal logic withgpaa_valuesprocesses either functionality accordingly.Quick Loom:
https://www.loom.com/share/b0633a46e44547189ca51954d524d5c4