gw-format-date-merge-tags.php: Added i18n date format support.
#919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
74
to
76
| if ( $locale ) { | ||
| $formatter = datefmt_create( | ||
| $locale, | ||
| IntlDateFormatter::FULL, | ||
| IntlDateFormatter::FULL, | ||
| null, | ||
| null, | ||
| $modifier | ||
| ); | ||
| $replace = $formatter->format( $timestamp ); | ||
| } else { | ||
| // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date | ||
| $replace = date( $modifier, $timestamp ); | ||
| } |
Contributor
There was a problem hiding this comment.
Curious, if you use https://developer.wordpress.org/reference/functions/wp_date/, does that solve the issue?
|
|
||
| new GW_Format_Date_Merge_Tag( array( | ||
| 'form_id' => 123, | ||
| 'locale' => 'fr_FR', // When this option is enabled, use the ISO date format codes instead. See https://framework.zend.com/manual/1.12/en/zend.date.constants.html#zend.date.constants.selfdefinedformats |
Contributor
There was a problem hiding this comment.
I'd comment this line out, as most people likely won't want French formatted dates 😃
barthc
force-pushed
the
barth/add/73925-support-i18n
branch
from
4502624 to
cce75d6
Compare
claygriffiths
approved these changes
Nov 19, 2024
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
One final bit of feedback, otherwise LGTM!
Comment on lines
74
to
76
| if ( $locale ) { | ||
| switch_to_locale( $locale ); | ||
| } |
Contributor
There was a problem hiding this comment.
I'd put a switch back to the other locale right before the return of this function, just to be safe.
$current_locale = determine_locale();
claygriffiths
approved these changes
Nov 19, 2024
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
Perfect! Nice work. S&M
barthc
force-pushed
the
barth/add/73925-support-i18n
branch
from
3861381 to
e4d5747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ https://secure.helpscout.net/conversation/2763010990/73925?folderId=8114575
Summary
Added
i18nsupport for date format using theIntlDateFormatterThisIntlDateFormatteruses the ISO date format codes instead of PHP date format.