Skip to content

Conversation

@saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2806641061/76034

Summary

The functionality to Add New with the snippet above doesn't work if no result is populated into the field.

BEFORE (Samuel):
https://www.loom.com/share/fc8ada4515724f3e8a76294da9910c33?sid=c12dbaf0-3a19-4265-b7a5-4435ac2f8e71

AFTER:
https://www.loom.com/share/fc15e97fed40415899d55be5fc84339e

@saifsultanc saifsultanc added the enhancement New feature or request label Jan 3, 2025
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. The only potential suggestion I have is to make the “No Results” text more easily customizable using this snippet.

I tweaked the PR title. S&M

@claygriffiths claygriffiths changed the title gpadvs-enable-add-new-option.php: Added new choice option for GPPA No Choice scenario. gpadvs-enable-add-new-option.php: Added ability to add new options when "No Results" are returned from Populate Anything. Jan 3, 2025
@github-actions
Copy link

github-actions bot commented Jan 3, 2025

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 734a1a5

@saifsultanc saifsultanc merged commit 65044dc into master Jan 6, 2025
5 checks passed
@saifsultanc saifsultanc deleted the saif/add/76034-add-new-choice-for-gppa-empty branch January 6, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants