-
-
Notifications
You must be signed in to change notification settings - Fork 75
feat(daffio): render ToC from page contents #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daffio): render ToC from page contents #3637
Conversation
|
@xelaint I've added a feature that will allow ToCs to be autogenerated from page content, LMK what you think. We need to add scrolling to the ToC, it will overflow off the page for large docs like |
|
I'm getting these two different errors in console when I visit design pages |
5435e75 to
350a457
Compare
350a457 to
2805635
Compare
|
@xelaint so there are a lot of changes here but to summarize:
|
xelaint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/docs/api/cart-store-credit these main API package pages don't need a TOC.
|
@griest024 The mobile TOC (On this page sidebar) on some pages don't have data (e.g. |
fixed |


PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3600, fixes #3733
What is the new behavior?
Does this PR introduce a breaking change?
Other information