fix(daffio): reconfigure how docs are loaded for ssr #3947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, linting just needs to be fixed. |
…ronments Previously, both @xelaint and I have errors at run time while working locally (and at serve when using a local ssr dev server) as a result of various usages of process.cwd(). Now, we no longer rely on process.cwd() instead, we determine whether or not we're using the Angular dev server and decide how to long assets from there. In addition, when running locally with a ssr server (not vite) we know grab the assets from the built browser folder.
damienwebdev
force-pushed
the
rework-daffio-docs-loaders
branch
from
e928074 to
f40c0a2
Compare
xelaint
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously, both @xelaint and I have errors at run time while working locally (and at serve when using a local ssr dev server) as a result of various usages of process.cwd().
Fixes: N/A
What is the new behavior?
Now, we no longer rely on process.cwd() instead, we determine whether or not we're using the Angular dev server and decide how to long assets from there. In addition, when running locally with a ssr server (not vite) we know grab the assets from the built browser folder.
Does this PR introduce a breaking change?
Other information