Call this._super() from init #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEPRECATION: Overriding init without calling this._super is deprecated. Please call this._super(), addon: `undefined`
Collaborator
Author
|
@green-arrow How do you feel about this change? |
Owner
|
@jheth - Thanks for this! Also, if you or anyone else is interested, I'm not maintaining this project anymore. If anyone else would like to pick it up, please let me know. |
Collaborator
Author
|
@green-arrow I'm interested in picking this up. We can keep it here if you want to make me a collaborator. |
Owner
|
@jheth - Sorry for the delay on this. Just added you as a collaborator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATION: Overriding init without calling this._super is deprecated. Please call this._super(), addon:
undefined