GCI99 OptimizeSquareComputation #Python #DLG #Build #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
…ations version and rename rule GCI99 to GCI97 Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Python rule (GCI99) to detect and flag inefficient square computations (x**2 and math.pow(x, 2)) and suggests using x*x instead. Key changes include:
- Implementation of the
OptimizeSquareComputationrule in Java. - Addition of Python test cases and a JUnit test.
- Registration of the new rule, bumping of the spec version, and changelog update.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/checks/optimizeSquareComputation.py | Adds sample Python cases marked noncompliant for square ops. |
| src/test/java/org/greencodeinitiative/creedengo/python/checks/OptimizeSquareComputationTest.java | Adds a JUnit test invoking the new rule. |
| src/main/java/org/greencodeinitiative/creedengo/python/checks/OptimizeSquareComputation.java | Implements the logic to flag **2 and math.pow(..., 2). |
| src/main/java/org/greencodeinitiative/creedengo/python/PythonRuleRepository.java | Registers the new rule in the repository. |
| pom.xml | Bumps creedengo-rules-specifications to 2.3.0. |
| CHANGELOG.md | Documents addition of rule GCI99. |
dedece35
requested changes
Jul 12, 2025
There was a problem hiding this comment.
add an integration test like explained in another PR : #71 (review)
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
dedece35
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that the rule does not exist.
Confirmed that the rule is not listed in Rules.MD, so a new ID GCI99 was created.
Added a corresponding Python unit test.
Updated the CHANGELOG accordingly.