GCI106 AvoidSqrtInLoop #Python #DLG #Build #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
Co-authored-by: DataLabGroupe-CreditAgricole <GITHUB.DATALABGROUPE@CREDIT-AGRICOLE-SA.FR>
dedece35
previously approved these changes
Jul 23, 2025
|
please check feedbacks of Copilot above. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new rule GCI106 "AvoidSqrtInLoop" to detect and flag uses of scalar square root functions (math.sqrt and numpy.sqrt) within loops. The rule promotes using vectorized operations on arrays instead of scalar operations in loops for better performance and energy efficiency.
- Implementation of the AvoidSqrtInLoop check that detects sqrt calls within for/while loops
- Addition of comprehensive test cases covering various compliant and non-compliant scenarios
- Integration of the new rule into the plugin configuration and test suite
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/main/java/org/greencodeinitiative/creedengo/python/checks/AvoidSqrtInLoop.java |
Main implementation of the GCI106 rule that detects sqrt calls in loops |
src/test/java/org/greencodeinitiative/creedengo/python/checks/AvoidSqrtInLoopTest.java |
Unit test for the new rule |
src/test/resources/checks/avoidSqrtInLoop.py |
Test cases with compliant and non-compliant code examples |
src/main/java/org/greencodeinitiative/creedengo/python/PythonRuleRepository.java |
Registration of the new rule in the repository |
src/main/resources/org/greencodeinitiative/creedengo/python/creedengo_way_profile.json |
Addition of GCI106 to the profile |
src/it/test-projects/creedengo-python-plugin-test-project/src/avoidSqrtInLoop.py |
Integration test file |
src/it/java/org/greencodeinitiative/creedengo/python/integration/tests/GCIRulesIT.java |
Integration test for the new rule |
pom.xml |
Version bump for creedengo-rules-specifications |
CHANGELOG.md |
Documentation of the new rule addition |
src/it/java/org/greencodeinitiative/creedengo/python/integration/tests/GCIRulesIT.java
Show resolved
Hide resolved
dedece35
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that the rule does not exist.
Confirmed that the rule is not listed in Rules.MD, so a new ID GCI106 was created.
Added a corresponding Python unit test.
Updated the CHANGELOG accordingly.