Skip to content

Commit 095c51b

Browse files
arndbgregkh
authored andcommitted
media: venus: fix QCOM_MDT_LOADER dependency
commit aa23c94 upstream. When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_VENUS=y, the kernel fails to link: x86_64-linux-ld: drivers/media/platform/qcom/venus/firmware.o: in function `venus_boot': firmware.c:(.text+0x1e3): undefined reference to `qcom_mdt_get_size' firmware.c:(.text+0x25a): undefined reference to `qcom_mdt_load' firmware.c:(.text+0x272): undefined reference to `qcom_mdt_load_no_init' The problem is the conditional 'select' statement. Change this to make the driver built-in here regardless of CONFIG_ARCH_QCOM, same as for the similar IRIS driver. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com> Fixes: 0399b69 ("media: venus: fix compile-test build on non-qcom ARM platform") Cc: stable@vger.kernel.org Signed-off-by: Bryan O'Donoghue <bod@kernel.org> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent e56a252 commit 095c51b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/media/platform/qcom/venus

drivers/media/platform/qcom/venus/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ config VIDEO_QCOM_VENUS
44
depends on VIDEO_DEV && QCOM_SMEM
55
depends on (ARCH_QCOM && ARM64 && IOMMU_API) || COMPILE_TEST
66
select OF_DYNAMIC if ARCH_QCOM
7-
select QCOM_MDT_LOADER if ARCH_QCOM
7+
select QCOM_MDT_LOADER
88
select QCOM_SCM
99
select VIDEOBUF2_DMA_CONTIG
1010
select V4L2_MEM2MEM_DEV

0 commit comments

Comments
 (0)