Skip to content

Commit 206f812

Browse files
Rob Clarkgregkh
authored andcommitted
drm/msm: Fix VM_BIND UNMAP locking
[ Upstream commit 85042c2 ] Wrong argument meant that the objs involved in UNMAP ops were not always getting locked. Since _NO_SHARE objs share a common resv with the VM (which is always locked) this would only show up with non-_NO_SHARE BOs. Reported-by: Victoria Brekenfeld <victoria@system76.com> Fixes: 2e6a8a1 ("drm/msm: Add VM_BIND ioctl") Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/94 Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/713898/ Message-ID: <20260324220519.1221471-2-robin.clark@oss.qualcomm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 8cf1897 commit 206f812

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/msm/msm_gem_vma.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1232,7 +1232,7 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec)
12321232
case MSM_VM_BIND_OP_UNMAP:
12331233
ret = drm_gpuvm_sm_unmap_exec_lock(job->vm, exec,
12341234
op->iova,
1235-
op->obj_offset);
1235+
op->range);
12361236
break;
12371237
case MSM_VM_BIND_OP_MAP:
12381238
case MSM_VM_BIND_OP_MAP_NULL: {

0 commit comments

Comments
 (0)