Skip to content

Commit 2e0fd1c

Browse files
jacquelinewonggregkh
authored andcommitted
tpm: tpm_tis: add error logging for data transfer
commit 0471921 upstream. Add logging to more easily determine reason for transmit failure Cc: stable@vger.kernel.org # v6.6+ Fixes: 280db21 ("tpm_tis: Resend command to recover from data transfer errors") Signed-off-by: Jacqueline Wong <jacqwong@google.com> Signed-off-by: Jordan Hand <jhand@google.com> Link: https://lore.kernel.org/r/20260415160006.2275325-2-jacqwong@google.com Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a866e2b commit 2e0fd1c

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/char/tpm/tpm_tis_core.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
472472
status = tpm_tis_status(chip);
473473
if (!itpm && (status & TPM_STS_DATA_EXPECT) == 0) {
474474
rc = -EIO;
475+
dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be set. sts = 0x%08x\n",
476+
status);
475477
goto out_err;
476478
}
477479
}
@@ -492,6 +494,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
492494
status = tpm_tis_status(chip);
493495
if (!itpm && (status & TPM_STS_DATA_EXPECT) != 0) {
494496
rc = -EIO;
497+
dev_err(&chip->dev, "TPM_STS_DATA_EXPECT should be unset. sts = 0x%08x\n",
498+
status);
495499
goto out_err;
496500
}
497501

0 commit comments

Comments
 (0)