Skip to content

Commit 30e8a2f

Browse files
jgunthorpegregkh
authored andcommitted
RDMA/mana: Fix error unwind in mana_ib_create_qp_rss()
commit 6aaa978 upstream. Sashiko points out that mana_ib_cfg_vport_steering() is leaked, the normal destroy path cleans it up. Cc: stable@vger.kernel.org Fixes: 0266a17 ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter") Link: https://sashiko.dev/#/patchset/0-v1-e911b76a94d1%2B65d95-rdma_udata_rep_jgg%40nvidia.com?part=4 Link: https://patch.msgid.link/r/7-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com Reviewed-by: Long Li <longli@microsoft.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a4570c8 commit 30e8a2f

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • drivers/infiniband/hw/mana

drivers/infiniband/hw/mana/qp.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,13 +235,15 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd,
235235
ibdev_dbg(&mdev->ib_dev,
236236
"Failed to copy to udata create rss-qp, %d\n",
237237
ret);
238-
goto fail;
238+
goto err_disable_vport_rx;
239239
}
240240

241241
kfree(mana_ind_table);
242242

243243
return 0;
244244

245+
err_disable_vport_rx:
246+
mana_disable_vport_rx(mpc);
245247
fail:
246248
while (i-- > 0) {
247249
ibwq = ind_tbl->ind_tbl[i];

0 commit comments

Comments
 (0)