Skip to content
/ linux Public

Commit 332fb84

Browse files
affenull2345Sasha Levin
authored andcommitted
mailbox: sprd: mask interrupts that are not handled
[ Upstream commit 75df94d ] To reduce the amount of spurious interrupts, disable the interrupts that are not handled in this driver. Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 17ee468 commit 332fb84

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

drivers/mailbox/sprd-mailbox.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -244,21 +244,19 @@ static int sprd_mbox_startup(struct mbox_chan *chan)
244244
/* Select outbox FIFO mode and reset the outbox FIFO status */
245245
writel(0x0, priv->outbox_base + SPRD_MBOX_FIFO_RST);
246246

247-
/* Enable inbox FIFO overflow and delivery interrupt */
248-
val = readl(priv->inbox_base + SPRD_MBOX_IRQ_MSK);
249-
val &= ~(SPRD_INBOX_FIFO_OVERFLOW_IRQ | SPRD_INBOX_FIFO_DELIVER_IRQ);
247+
/* Enable inbox FIFO delivery interrupt */
248+
val = SPRD_INBOX_FIFO_IRQ_MASK;
249+
val &= ~SPRD_INBOX_FIFO_DELIVER_IRQ;
250250
writel(val, priv->inbox_base + SPRD_MBOX_IRQ_MSK);
251251

252252
/* Enable outbox FIFO not empty interrupt */
253-
val = readl(priv->outbox_base + SPRD_MBOX_IRQ_MSK);
253+
val = SPRD_OUTBOX_FIFO_IRQ_MASK;
254254
val &= ~SPRD_OUTBOX_FIFO_NOT_EMPTY_IRQ;
255255
writel(val, priv->outbox_base + SPRD_MBOX_IRQ_MSK);
256256

257257
/* Enable supplementary outbox as the fundamental one */
258258
if (priv->supp_base) {
259259
writel(0x0, priv->supp_base + SPRD_MBOX_FIFO_RST);
260-
val = readl(priv->supp_base + SPRD_MBOX_IRQ_MSK);
261-
val &= ~SPRD_OUTBOX_FIFO_NOT_EMPTY_IRQ;
262260
writel(val, priv->supp_base + SPRD_MBOX_IRQ_MSK);
263261
}
264262
}

0 commit comments

Comments
 (0)